-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(crashlytics): deprecation warning for v8 API ahead of future major release #8107
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍿 ! "and so it begins..."
I wonder though - this seems like a lot of repetition required in 2x the places (alters modular and old-style implementations), and 2x the work since there will be removal required in the modular API when deprecation complete
Related thought: the modular implementation will eventually host the actual implementation, inverting the current situation where old-style has the implementation and modular delegates, that is a necessary change that is unavoidable when removing the old-style implementation
So with this style it is:
1- add deprecation machinery to modular and old-style (2 spots)
2- move implementation from old-style to modular (unavoidable)
3- remove old-style and deprecation machinery from modular (2 spot)
I wonder if re-ordering it would be more efficient, and lead to cleaner deprecation addition:
1- move implementation from old-style to modular (unavoidable anyway)
2- add deprecation to old-style (only 1 spot, doesn't pollute modular)
3- remove old-style (only 1 spot)
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
console.warn()
's are called for v8 API as opposed to v9 API.Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter